From 18c54a29783468d7866bd47a63cdd1168e33676b Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Wed, 17 Jul 2024 23:25:25 -0500 Subject: [PATCH] fix: dangling raw_ptr in api::View (#42952) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_view.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/browser/api/electron_api_view.cc b/shell/browser/api/electron_api_view.cc index 9bb51a8e2d10..b15ec727d079 100644 --- a/shell/browser/api/electron_api_view.cc +++ b/shell/browser/api/electron_api_view.cc @@ -178,7 +178,7 @@ View::~View() { return; view_->RemoveObserver(this); if (delete_view_) - delete view_; + view_.ClearAndDelete(); } void View::ReorderChildView(gin::Handle child, size_t index) {