mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

removed will-navigate and did-navigate events

Browse source
This commit is contained in:
deepak1556 2015-04-25 09:50:11 +05:30
parent 05be71e9bc
commit 18b3dfa350
8 changed files with 5 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

1
atom/renderer/lib/web-view/guest-view-internal.coffee
View file

@ -7,7 +7,6 @@ WEB_VIEW_EVENTS =
'did-finish-load': []
'did-fail-load': ['errorCode', 'errorDescription']
'did-frame-finish-load': ['isMainFrame']
'did-navigate': []
'did-start-loading': []
'did-stop-loading': []
'did-get-response-details': ['status', 'newUrl', 'originalUrl',

15
atom/renderer/lib/web-view/web-view-attributes.coffee
View file

@ -154,14 +154,6 @@ class SrcAttribute extends WebViewAttribute
not @.getValue()
return
# Allow users to cancel webview navigation.
domEvent = new Event('will-navigate')
domEvent['url'] = @getValue()
domEvent.cancelable = true
domEvent.preventDefault = () =>
@setValueIgnoreMutation ''
@webViewImpl.webviewNode.dispatchEvent domEvent
unless @webViewImpl.guestInstanceId?
if @webViewImpl.beforeFirstNavigation
@webViewImpl.beforeFirstNavigation = false
@ -169,10 +161,9 @@ class SrcAttribute extends WebViewAttribute
return
# Navigate to |this.src|.
if @getValue()
httpreferrer = @webViewImpl.attributes[webViewConstants.ATTRIBUTE_HTTPREFERRER].getValue()
urlOptions = if httpreferrer then {httpreferrer} else {}
remote.getGuestWebContents(@webViewImpl.guestInstanceId).loadUrl @getValue(), urlOptions
httpreferrer = @webViewImpl.attributes[webViewConstants.ATTRIBUTE_HTTPREFERRER].getValue()
urlOptions = if httpreferrer then {httpreferrer} else {}
remote.getGuestWebContents(@webViewImpl.guestInstanceId).loadUrl @getValue(), urlOptions
# Attribute specifies HTTP referrer.
class HttpReferrerAttribute extends WebViewAttribute