mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

build: re-enable self-cert codesigning on x64 macOS (#42576)

Browse source 
build: re-enable self-cert codesigning
This commit is contained in:
Shelley Vohr 2024-06-19 16:28:07 +02:00 committed by GitHub
parent dad6e130f5
commit 18abeb3add
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
.github/workflows/pipeline-segment-electron-test.yml vendored
View file

@ -130,12 +130,12 @@ jobs:
unzip -:o dist.zip unzip -:o dist.zip
unzip -:o chromedriver.zip unzip -:o chromedriver.zip
unzip -:o mksnapshot.zip unzip -:o mksnapshot.zip
# - name: Import & Trust Self-Signed Codesigning Cert on MacOS - name: Import & Trust Self-Signed Codesigning Cert on MacOS
# if: ${{ inputs.target-platform == 'macos' }} if: ${{ inputs.target-platform == 'macos' && inputs.target-arch == 'x64' }}
# run: | run: |
# sudo security authorizationdb write com.apple.trust-settings.admin allow sudo security authorizationdb write com.apple.trust-settings.admin allow
# cd src/electron cd src/electron
# ./script/codesign/generate-identity.sh ./script/codesign/generate-identity.sh
- name: Run Electron Tests - name: Run Electron Tests
shell: bash shell: bash
env: env:

2
spec/lib/codesign-helpers.ts
View file

@ -8,7 +8,7 @@ const fixturesPath = path.resolve(__dirname, '..', 'fixtures');
export const shouldRunCodesignTests = export const shouldRunCodesignTests =
process.platform === 'darwin' && process.platform === 'darwin' &&
!process.env.CI && !(process.env.CI && process.arch === 'arm64') &&
!process.mas && !process.mas &&
!features.isComponentBuild(); !features.isComponentBuild();