mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: give ASAN tests more memory to avoid SIGKILL or disabling tests (#28567)

Browse source 
* build: give ASAN tests more memory

* test: re-eanble asan tests

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
This commit is contained in:
Samuel Attard 2021-04-09 00:09:17 -07:00 • committed by GitHub
parent f73d09374e
commit 17f527f757
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 18 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec-main/node-spec.ts
View file

@ -23,8 +23,7 @@ describe('node feature', () => {
});
});
// Running child app under ASan might receive SIGKILL because of OOM.
ifit(!process.env.IS_ASAN)('does not hang when using the fs module in the renderer process', async () => {
it('does not hang when using the fs module in the renderer process', async () => {
const appPath = path.join(mainFixturesPath, 'apps', 'libuv-hang', 'main.js');
const appProcess = childProcess.spawn(process.execPath, [appPath], {
cwd: path.join(mainFixturesPath, 'apps', 'libuv-hang'),
@ -135,8 +134,7 @@ describe('node feature', () => {
});
});
// Running child app under ASan might receive SIGKILL because of OOM.
ifdescribe(features.isRunAsNodeEnabled() && !process.env.IS_ASAN)('Node.js cli flags', () => {
ifdescribe(features.isRunAsNodeEnabled())('Node.js cli flags', () => {
let child: childProcess.ChildProcessWithoutNullStreams;
let exitPromise: Promise<any[]>;
@ -178,8 +176,7 @@ describe('node feature', () => {
});
});
// Running child app under ASan might receive SIGKILL because of OOM.
ifdescribe(features.isRunAsNodeEnabled() && !process.env.IS_ASAN)('inspector', () => {
ifdescribe(features.isRunAsNodeEnabled())('inspector', () => {
let child: childProcess.ChildProcessWithoutNullStreams;
let exitPromise: Promise<any[]>;
@ -317,8 +314,7 @@ describe('node feature', () => {
});
});
// Running child app under ASan might receive SIGKILL because of OOM.
ifit(!process.env.IS_ASAN)('Can find a module using a package.json main field', () => {
it('Can find a module using a package.json main field', () => {
const result = childProcess.spawnSync(process.execPath, [path.resolve(fixtures, 'api', 'electron-main-module', 'app.asar')]);
expect(result.status).to.equal(0);
});