mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #10708 from electron/remote-node-warning

Browse source 
Warn if loading remote content with nodeIntegration
This commit is contained in:
Felix Rieseberg 2017-10-06 16:17:52 -07:00 committed by GitHub
commit 1761d5da06
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/renderer/init.js
View file

@ -129,6 +129,15 @@ if (nodeIntegration === 'true') {
} }
} }
if (/(https?)|(ftp):/.test(window.location.protocol)) {
let warning = 'This renderer process has Node.js integration enabled '
warning += 'and attempted to load remote content. This exposes users of this app to severe '
warning += 'security risks.\n'
warning += 'For more information and help, consult https://electron.atom.io/docs/tutorial/security/'
console.warn('%cElectron Security Warning', 'font-weight: bold;', warning)
}
// Redirect window.onerror to uncaughtException. // Redirect window.onerror to uncaughtException.
window.onerror = function (message, filename, lineno, colno, error) { window.onerror = function (message, filename, lineno, colno, error) {
if (global.process.listeners('uncaughtException').length > 0) { if (global.process.listeners('uncaughtException').length > 0) {