mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: do not ignore electron exit signals in cli.js wrapper (#22878)

Browse source 
When the electron child process exits with a signal, the close event
handler receives code null and the cli wrapper would silently exit
successfully.  Fix it to log a message and exit with a nonzero code in
this case.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg 2020-04-12 23:49:01 -07:00 committed by GitHub
parent 27d6266b2d
commit 1746ae8c35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
npm/cli.js
View file

@ -5,7 +5,11 @@ var electron = require('./')
var proc = require('child_process') var proc = require('child_process')
var child = proc.spawn(electron, process.argv.slice(2), { stdio: 'inherit', windowsHide: false }) var child = proc.spawn(electron, process.argv.slice(2), { stdio: 'inherit', windowsHide: false })
child.on('close', function (code) { child.on('close', function (code, signal) {
if (code === null) {
console.error(electron, 'exited with signal', signal)
process.exit(1)
}
process.exit(code) process.exit(code)
}) })