fix: maxWidth not being respected (#32628)

This commit is contained in:
Jeremy Rose 2022-01-26 14:00:17 -08:00 committed by GitHub
parent 7caa88c46f
commit 16fcad3488
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -161,16 +161,16 @@ void NativeWindow::InitFromOptions(const gin_helper::Dictionary& options) {
// On Linux and Window we may already have maximum size defined.
extensions::SizeConstraints size_constraints(
use_content_size ? GetContentSizeConstraints() : GetSizeConstraints());
int min_height = 0, min_width = 0;
if (options.Get(options::kMinHeight, &min_height) ||
options.Get(options::kMinWidth, &min_width)) {
int min_width = size_constraints.GetMinimumSize().width();
int min_height = size_constraints.GetMinimumSize().height();
options.Get(options::kMinWidth, &min_width);
options.Get(options::kMinHeight, &min_height);
size_constraints.set_minimum_size(gfx::Size(min_width, min_height));
}
int max_height = INT_MAX, max_width = INT_MAX;
if (options.Get(options::kMaxHeight, &max_height) ||
options.Get(options::kMaxWidth, &max_width)) {
int max_width = size_constraints.GetMaximumSize().width();
int max_height = size_constraints.GetMaximumSize().height();
options.Get(options::kMaxWidth, &max_width);
options.Get(options::kMaxHeight, &max_height);
size_constraints.set_maximum_size(gfx::Size(max_width, max_height));
}
if (use_content_size) {
SetContentSizeConstraints(size_constraints);
} else {