chore: bump chromium to 108.0.5329.0 (main) (#35628)
Co-authored-by: Samuel Attard <sattard@salesforce.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
This commit is contained in:
parent
94955a7999
commit
16f459228b
178 changed files with 1000 additions and 936 deletions
|
@ -49,3 +49,5 @@ v8_api_advance_api_deprecation.patch
|
|||
enable_-wunqualified-std-cast-call.patch
|
||||
fixup_for_error_declaration_shadows_a_local_variable.patch
|
||||
fixup_for_wc_98-compat-extra-semi.patch
|
||||
drop_deserializerequest_move_constructor_for_c_20_compat.patch
|
||||
fix_parallel_test-v8-stats.patch
|
||||
|
|
|
@ -7,10 +7,10 @@ This adds GN build files for Node, so we don't have to build with GYP.
|
|||
|
||||
diff --git a/BUILD.gn b/BUILD.gn
|
||||
new file mode 100644
|
||||
index 0000000000000000000000000000000000000000..3ae9b93649bb404fbf04dea52ecaa7d664ff03ee
|
||||
index 0000000000000000000000000000000000000000..a47875642d8f825c84ba1e82e3892a97e98e76e4
|
||||
--- /dev/null
|
||||
+++ b/BUILD.gn
|
||||
@@ -0,0 +1,440 @@
|
||||
@@ -0,0 +1,438 @@
|
||||
+import("//v8/gni/v8.gni")
|
||||
+import("node.gni")
|
||||
+
|
||||
|
@ -123,8 +123,6 @@ index 0000000000000000000000000000000000000000..3ae9b93649bb404fbf04dea52ecaa7d6
|
|||
+ } else {
|
||||
+ defines += [ "HAVE_OPENSSL=0" ]
|
||||
+ }
|
||||
+ # boringssl does not support SSL_trace, let's disable it
|
||||
+ defines += ["OPENSSL_NO_SSL_TRACE=1"]
|
||||
+ if (v8_enable_i18n_support) {
|
||||
+ defines += [ "NODE_HAVE_I18N_SUPPORT=1" ]
|
||||
+ } else {
|
||||
|
|
|
@ -0,0 +1,37 @@
|
|||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||
From: Jeremy Rose <japthorp@slack-corp.com>
|
||||
Date: Mon, 26 Sep 2022 14:44:57 -0700
|
||||
Subject: drop DeserializeRequest move constructor for c++20 compat
|
||||
|
||||
C++20 was enabled on mac in
|
||||
https://chromium-review.googlesource.com/c/chromium/src/+/3914624, which caused
|
||||
initialization of DeserializeRequest to fail:
|
||||
|
||||
../../third_party/electron_node/src/env.cc:1835:22: error: no matching constructor for initialization of 'DeserializeRequest'
|
||||
DeserializeRequest request{cb, {isolate(), holder}, index};
|
||||
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
||||
../../third_party/electron_node/src/env.h:944:3: note: candidate constructor not viable: requires single argument 'other', but 3 arguments were provided
|
||||
DeserializeRequest(DeserializeRequest&& other) = default;
|
||||
^
|
||||
../../third_party/electron_node/src/env.h:937:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 3 were provided
|
||||
struct DeserializeRequest {
|
||||
^
|
||||
|
||||
I think (though not 100% sure) that this is because the one explicitly
|
||||
specified move constructor "shadows" the implicit initializer-list constructor.
|
||||
This patch seems to fix things, in any case.
|
||||
|
||||
diff --git a/src/env.h b/src/env.h
|
||||
index 6b18b6efd231d986c391a16966fdbc82a5d99eda..099d8c9efeeda1c851d526e4bf4ddece444c7299 100644
|
||||
--- a/src/env.h
|
||||
+++ b/src/env.h
|
||||
@@ -939,9 +939,6 @@ struct DeserializeRequest {
|
||||
v8::Global<v8::Object> holder;
|
||||
int index;
|
||||
InternalFieldInfo* info = nullptr; // Owned by the request
|
||||
-
|
||||
- // Move constructor
|
||||
- DeserializeRequest(DeserializeRequest&& other) = default;
|
||||
};
|
||||
|
||||
struct EnvSerializeInfo {
|
22
patches/node/fix_parallel_test-v8-stats.patch
Normal file
22
patches/node/fix_parallel_test-v8-stats.patch
Normal file
|
@ -0,0 +1,22 @@
|
|||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||
From: Jeremy Rose <japthorp@slack-corp.com>
|
||||
Date: Thu, 29 Sep 2022 16:30:17 -0700
|
||||
Subject: fix parallel/test-v8-stats
|
||||
|
||||
new heap spaces were added in v8, this updates the expectations to
|
||||
match. node should eventually have this too once they roll up the newer
|
||||
v8.
|
||||
|
||||
diff --git a/test/parallel/test-v8-stats.js b/test/parallel/test-v8-stats.js
|
||||
index 7503a08c5a67fa4bead4f768242b47f418ebfc85..98ad11f11f9b9bf5699801814f8234e84dfaf638 100644
|
||||
--- a/test/parallel/test-v8-stats.js
|
||||
+++ b/test/parallel/test-v8-stats.js
|
||||
@@ -46,6 +46,8 @@ const expectedHeapSpaces = [
|
||||
'new_space',
|
||||
'old_space',
|
||||
'read_only_space',
|
||||
+ 'shared_large_object_space',
|
||||
+ 'shared_space'
|
||||
];
|
||||
const heapSpaceStatistics = v8.getHeapSpaceStatistics();
|
||||
const actualHeapSpaceNames = heapSpaceStatistics.map((s) => s.space_name);
|
Loading…
Add table
Add a link
Reference in a new issue