From 1660fc8d139813cfa85944fe3851dfcfcf827845 Mon Sep 17 00:00:00 2001 From: Ted Kim Date: Mon, 20 Nov 2017 10:15:45 +0900 Subject: [PATCH] Fix getLoginItemSettings timing issue --- spec/api-app-spec.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/spec/api-app-spec.js b/spec/api-app-spec.js index 2997966f557..6f028b09e9c 100644 --- a/spec/api-app-spec.js +++ b/spec/api-app-spec.js @@ -347,7 +347,7 @@ describe('app module', () => { app.setLoginItemSettings({openAtLogin: false, path: updateExe, args: processStartArgs}) }) - it('returns the login item status of the app', () => { + it('returns the login item status of the app', (done) => { app.setLoginItemSettings({openAtLogin: true}) assert.deepEqual(app.getLoginItemSettings(), { openAtLogin: true, @@ -367,13 +367,18 @@ describe('app module', () => { }) app.setLoginItemSettings({}) - assert.deepEqual(app.getLoginItemSettings(), { - openAtLogin: false, - openAsHidden: false, - wasOpenedAtLogin: false, - wasOpenedAsHidden: false, - restoreState: false - }) + // Wait because login item settings are not applied immediately in MAS build + const delay = process.mas ? 100 : 0; + setTimeout(() => { + assert.deepEqual(app.getLoginItemSettings(), { + openAtLogin: false, + openAsHidden: false, + wasOpenedAtLogin: false, + wasOpenedAsHidden: false, + restoreState: false + }) + done() + }, delay); }) it('allows you to pass a custom executable and arguments', () => {