From 1621fcf5d37de3163edfac5c31962d24b862d070 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Tue, 13 Jun 2023 21:15:20 +0200 Subject: [PATCH] docs: add missing isSameDocument property to will-frame-navigate event details (#37940) Co-authored-by: Milan Burda --- docs/api/web-contents.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md index f2175ba7d238..fb123983169d 100644 --- a/docs/api/web-contents.md +++ b/docs/api/web-contents.md @@ -239,9 +239,8 @@ Returns: * `details` Event<> * `url` string - The URL the frame is navigating to. - * `isSameDocument` boolean - Whether the navigation happened without changing - document. Examples of same document navigations are reference fragment - navigations, pushState/replaceState, and same page history navigation. + * `isSameDocument` boolean - This event does not fire for same document navigations using window.history api and reference fragment navigations. + This property is always set to `false` for this event. * `isMainFrame` boolean - True if the navigation is taking place in a main frame. * `frame` WebFrameMain - The frame to be navigated. * `initiator` WebFrameMain (optional) - The frame which initiated the @@ -273,6 +272,8 @@ Returns: * `details` Event<> * `url` string - The URL the frame is navigating to. + * `isSameDocument` boolean - This event does not fire for same document navigations using window.history api and reference fragment navigations. + This property is always set to `false` for this event. * `isMainFrame` boolean - True if the navigation is taking place in a main frame. * `frame` WebFrameMain - The frame to be navigated. * `initiator` WebFrameMain (optional) - The frame which initiated the