mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: allow iframe-initiated HTML fullscreen to exit while in macOS fullscreen (#20962)

Browse source 
* fix: explicitly resize the contents when exiting html fullscreen while in OS fullscreen

* test: ensure HTML fullscreen toggles while in OS fullscreen
This commit is contained in:
loc 2019-11-05 16:34:45 -05:00 • committed by Samuel Attard
parent fcee7212ce
commit 15dffb3dde
4 changed files with 119 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/common_web_contents_delegate.cc
View file

@ -355,6 +355,13 @@ void CommonWebContentsDelegate::ExitFullscreenModeForTab(
return;
SetHtmlApiFullscreen(false);
owner_window_->NotifyWindowLeaveHtmlFullScreen();
if (native_fullscreen_) {
// Explicitly trigger a view resize, as the size is not actually changing if
// the browser is fullscreened, too. Chrome does this indirectly from
// `chrome/browser/ui/exclusive_access/fullscreen_controller.cc`.
source->GetRenderViewHost()->GetWidget()->SynchronizeVisualProperties();
}
}
bool CommonWebContentsDelegate::IsFullscreenForTabOrPending(