fix lint errors and add documentation

atom/app/atom_content_client.cc

@@ -10,16 +10,12 @@
 #include "atom/common/chrome_version.h"
 #include "atom/common/options_switches.h"
 #include "base/command_line.h"
-#include "base/strings/string_split.h"
-#include "base/strings/string_util.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/pepper_plugin_info.h"
 #include "ppapi/shared_impl/ppapi_permissions.h"
 
 namespace atom {
 
-int32 kPepperFlashPermissions = ppapi::PERMISSION_ALL_BITS;
-
 namespace {
 
 content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
@@ -29,7 +25,7 @@ namespace {
   plugin.is_out_of_process = true;
   plugin.name = content::kFlashPluginName;
   plugin.path = path;
-    plugin.permissions = kPepperFlashPermissions;
+  plugin.permissions = ppapi::PERMISSION_ALL_BITS;
   plugin.version = version;
 
   content::WebPluginMimeType swf_mime_type(

atom/browser/atom_browser_client.cc

@@ -202,6 +202,8 @@ void AtomBrowserClient::AppendExtraCommandLineSwitches(
 
 void AtomBrowserClient::DidCreatePpapiPlugin(
     content::BrowserPpapiHost* browser_host) {
+  auto command_line = base::CommandLine::ForCurrentProcess();
+  if (command_line->HasSwitch(switches::kEnablePlugins))
     browser_host->GetPpapiHost()->AddHostFactoryFilter(
         scoped_ptr<ppapi::host::HostFactory>(
             new chrome::ChromeBrowserPepperHostFactory(browser_host)));

docs/api/chrome-command-line-switches.md

@@ -62,6 +62,14 @@ Like `--host-rules` but these `rules` only apply to the host resolver.
 
 Ignore certificate related errors.
 
+## --ppapi-flash-path
+
+Set path to pepper flash plugin for use.
+
+## --ppapi-flash-version
+
+Set the pepper flash version.
+
 ## --v=`log_level`
 
 Gives the default maximal active V-logging level; 0 is the default. Normally