fix lint errors

This commit is contained in:
Vanessa Yuen 2017-08-01 11:50:57 -04:00
parent eaa63c880e
commit 1577360312
2 changed files with 15 additions and 17 deletions

View file

@ -2,7 +2,7 @@ const tape = require('tape')
const proxyquire = require('proxyquire') const proxyquire = require('proxyquire')
const path = require('path') const path = require('path')
const sinon = require('sinon') const sinon = require('sinon')
const admZip = require('adm-zip') const AdmZip = require('adm-zip')
const temp = require('temp') const temp = require('temp')
let sandbox let sandbox
@ -59,7 +59,6 @@ tape('fails for unsupported platforms', (t) => {
}) })
tape('extract file', (t) => { tape('extract file', (t) => {
sandbox.restore() sandbox.restore()
sandbox.stub(process, 'env').value( sandbox.stub(process, 'env').value(
@ -67,7 +66,7 @@ tape('extract file', (t) => {
) )
// add file directly // add file directly
const zip = new admZip() const zip = new AdmZip()
zip.addFile('test.txt', Buffer.from('electron install test')) zip.addFile('test.txt', Buffer.from('electron install test'))
zip.writeZip(path.join(tempDir, 'test.zip')) zip.writeZip(path.join(tempDir, 'test.zip'))

View file

@ -1,19 +1,18 @@
require('dotenv-safe').load() require('dotenv-safe').load()
const temp = require('temp'), const temp = require('temp')
fs = require('fs'), const fs = require('fs')
util = require('util'), const path = require('path')
path = require('path'), const childProcess = require('child_process')
childProcess = require('child_process'), const GitHubApi = require('github')
GitHubApi = require('github'), const request = require('request')
request = require('request'), const assert = require('assert')
rootPackageJson = require('../package.json'), const rootPackageJson = require('../package.json')
assert = require('assert')
const github = new GitHubApi({ const github = new GitHubApi({
// debug: true, // debug: true,
headers: { 'User-Agent': 'electron-npm-publisher' }, headers: { 'User-Agent': 'electron-npm-publisher' },
followRedirects: false, followRedirects: false
}) })
github.authenticate({ github.authenticate({
type: 'token', type: 'token',
@ -71,7 +70,7 @@ new Promise((resolve, reject) => {
return github.repos.getReleases({ return github.repos.getReleases({
owner: 'electron', owner: 'electron',
repo: 'electron', repo: 'electron'
}) })
}) })
.then((releases) => { .then((releases) => {
@ -81,13 +80,13 @@ new Promise((resolve, reject) => {
// (release) => release.draft && release.tag_name === `test` // (release) => release.draft && release.tag_name === `test`
) )
if (!draftRelease) { if (!draftRelease) {
throw `cannot find release with tag v${rootPackageJson.version}` throw new Error(`cannot find release with tag v${rootPackageJson.version}`)
} }
return draftRelease.assets.find((asset) => asset.name === 'electron.d.ts') return draftRelease.assets.find((asset) => asset.name === 'electron.d.ts')
}) })
.then((tsdAsset) => { .then((tsdAsset) => {
if (!tsdAsset) { if (!tsdAsset) {
throw `cannot find electron.d.ts from v${rootPackageJson.version} draft release assets` throw new Error(`cannot find electron.d.ts from v${rootPackageJson.version} draft release assets`)
} }
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
request.get({ request.get({
@ -115,7 +114,7 @@ new Promise((resolve, reject) => {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
childProcess.execSync(`npm install ${tarballPath} --force --silent`, { childProcess.execSync(`npm install ${tarballPath} --force --silent`, {
env: Object.assign({}, process.env, { electron_config_cache: distDir }), env: Object.assign({}, process.env, { electron_config_cache: distDir }),
cwd: tempDir, cwd: tempDir
}) })
const checkVersion = childProcess.exec(`${path.join(tempDir, 'node_modules', '.bin', 'electron')} -v`) const checkVersion = childProcess.exec(`${path.join(tempDir, 'node_modules', '.bin', 'electron')} -v`)
checkVersion.stdout.on('data', (data) => { checkVersion.stdout.on('data', (data) => {