From 14834f35dfa3d8e4d5017bcbb1b59c334e94b182 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 8 Apr 2021 00:28:02 -0700 Subject: [PATCH] build: add safety net for mac_deployment_target (#28517) As of #28480 we now dynamically determine the LSMinimumSystemVersion value as part of the build process. To avoid this changing and no one realizing we now have this assert which will trip during a Chromium upgrade if they bump the minimum supported macOS version so we can update our documentation appropriately. --- BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index c206e1e5775c..2e1bf143ae60 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -32,6 +32,10 @@ if (is_mac) { import("//ui/gl/features.gni") import("//v8/gni/v8.gni") import("build/rules.gni") + + assert( + mac_deployment_target == "10.11.0", + "Chromium has updated the mac_deployment_target, please update this assert, update the supported versions documentation (docs/tutorial/support.md) and flag this as a breaking change") } if (is_linux) {