mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Always enable harmony when node binding is on.

Browse source 
If we dont' do this we would have lots of "Extension or internal
compilation error." error, seems to be V8's bug.
This commit is contained in:
Cheng Zhao 2014-07-28 17:06:28 +08:00
parent a6ede12cd7
commit 143bde007a
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
atom/renderer/atom_renderer_client.cc
View file

@ -70,6 +70,10 @@ AtomRendererClient::AtomRendererClient()
node_integration_ = ALL;
if (IsNodeBindingEnabled()) {
// Always enable harmony when node binding is on.
std::string flags("--harmony");
v8::V8::SetFlagsFromString(flags.c_str(), static_cast<int>(flags.size()));
node_bindings_.reset(NodeBindings::Create(false));
atom_bindings_.reset(new AtomRendererBindings);
}