From 13fe994d0dc88356f3339ef4d78a2826a08d7da2 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 6 May 2025 16:12:09 +0200 Subject: [PATCH] fix: allowed dialog file types with one filter (#46945) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr --- shell/browser/ui/file_dialog_mac.mm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/shell/browser/ui/file_dialog_mac.mm b/shell/browser/ui/file_dialog_mac.mm index 99c46738256c..881054f0445d 100644 --- a/shell/browser/ui/file_dialog_mac.mm +++ b/shell/browser/ui/file_dialog_mac.mm @@ -131,10 +131,6 @@ void SetAllowedFileTypes(NSSavePanel* dialog, const Filters& filters) { [file_types_list addObject:content_types_set]; } - // Don't add file format picker. - if ([file_types_list count] <= 1) - return; - NSArray* content_types = [file_types_list objectAtIndex:0]; __block BOOL allowAllFiles = NO; @@ -148,6 +144,10 @@ void SetAllowedFileTypes(NSSavePanel* dialog, const Filters& filters) { [dialog setAllowedContentTypes:allowAllFiles ? @[] : content_types]; + // Don't add file format picker. + if ([file_types_list count] <= 1) + return; + // Add file format picker. ElectronAccessoryView* accessoryView = [[ElectronAccessoryView alloc] initWithFrame:NSMakeRect(0.0, 0.0, 200, 32.0)];