mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

spec: remove unused variables (#18947)

Browse source
This commit is contained in:
Milan Burda 2019-06-24 20:41:20 +02:00 committed by Charles Kerr
parent ed5c624b08
commit 1304f259cc
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
spec/api-subframe-spec.js
View file

@ -31,7 +31,7 @@ describe('renderer nodeIntegrationInSubFrames', () => {
}) })
it('should load preload scripts in top level iframes', async () => { it('should load preload scripts in top level iframes', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 2) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 2)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`))
const [event1, event2] = await detailsPromise const [event1, event2] = await detailsPromise
expect(event1[0].frameId).to.not.equal(event2[0].frameId) expect(event1[0].frameId).to.not.equal(event2[0].frameId)
@ -40,7 +40,7 @@ describe('renderer nodeIntegrationInSubFrames', () => {
}) })
it('should load preload scripts in nested iframes', async () => { it('should load preload scripts in nested iframes', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 3) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 3)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-with-frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-with-frame-container${fixtureSuffix}.html`))
const [event1, event2, event3] = await detailsPromise const [event1, event2, event3] = await detailsPromise
expect(event1[0].frameId).to.not.equal(event2[0].frameId) expect(event1[0].frameId).to.not.equal(event2[0].frameId)
@ -52,37 +52,37 @@ describe('renderer nodeIntegrationInSubFrames', () => {
}) })
it('should correctly reply to the main frame with using event.reply', async () => { it('should correctly reply to the main frame with using event.reply', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 2) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 2)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`))
const [event1] = await detailsPromise const [event1] = await detailsPromise
const pongPromise = emittedOnce(remote.ipcMain, 'preload-pong') const pongPromise = emittedOnce(ipcMain, 'preload-pong')
event1[0].reply('preload-ping') event1[0].reply('preload-ping')
const details = await pongPromise const details = await pongPromise
expect(details[1]).to.equal(event1[0].frameId) expect(details[1]).to.equal(event1[0].frameId)
}) })
it('should correctly reply to the sub-frames with using event.reply', async () => { it('should correctly reply to the sub-frames with using event.reply', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 2) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 2)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`))
const [, event2] = await detailsPromise const [, event2] = await detailsPromise
const pongPromise = emittedOnce(remote.ipcMain, 'preload-pong') const pongPromise = emittedOnce(ipcMain, 'preload-pong')
event2[0].reply('preload-ping') event2[0].reply('preload-ping')
const details = await pongPromise const details = await pongPromise
expect(details[1]).to.equal(event2[0].frameId) expect(details[1]).to.equal(event2[0].frameId)
}) })
it('should correctly reply to the nested sub-frames with using event.reply', async () => { it('should correctly reply to the nested sub-frames with using event.reply', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 3) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 3)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-with-frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-with-frame-container${fixtureSuffix}.html`))
const [, , event3] = await detailsPromise const [, , event3] = await detailsPromise
const pongPromise = emittedOnce(remote.ipcMain, 'preload-pong') const pongPromise = emittedOnce(ipcMain, 'preload-pong')
event3[0].reply('preload-ping') event3[0].reply('preload-ping')
const details = await pongPromise const details = await pongPromise
expect(details[1]).to.equal(event3[0].frameId) expect(details[1]).to.equal(event3[0].frameId)
}) })
it('should not expose globals in main world', async () => { it('should not expose globals in main world', async () => {
const detailsPromise = emittedNTimes(remote.ipcMain, 'preload-ran', 2) const detailsPromise = emittedNTimes(ipcMain, 'preload-ran', 2)
w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`)) w.loadFile(path.resolve(__dirname, `fixtures/sub-frames/frame-container${fixtureSuffix}.html`))
const details = await detailsPromise const details = await detailsPromise
const senders = details.map(event => event[0].sender) const senders = details.map(event => event[0].sender)
@ -176,9 +176,6 @@ describe('cross-site frame sandboxing', () => {
server = null server = null
}) })
const fixtures = path.resolve(__dirname, 'fixtures')
const preload = path.join(fixtures, 'module', 'preload-pid.js')
let w let w
afterEach(() => { afterEach(() => {