From 12b00ca9429c61a0e52df9d7ec6f50bc451e5f3e Mon Sep 17 00:00:00 2001 From: Jaime Bernardo Date: Thu, 22 Aug 2019 21:16:38 +0100 Subject: [PATCH] fix: extern Parse impl for Windows debug builds (#19876) * fix: extern Parse impl for Windows debug builds Applies a patch to node. Externs node::options_parser::Parse implementation for node::DebugOptions to fix the Windows Debug build. * fixup: merge extern parse impl patch --- ...uleenv_and_options_parser_for_debug_builds.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/patches/node/fix_extern_the_nativemoduleenv_and_options_parser_for_debug_builds.patch b/patches/node/fix_extern_the_nativemoduleenv_and_options_parser_for_debug_builds.patch index 2d100d121761..55e030cd7027 100644 --- a/patches/node/fix_extern_the_nativemoduleenv_and_options_parser_for_debug_builds.patch +++ b/patches/node/fix_extern_the_nativemoduleenv_and_options_parser_for_debug_builds.patch @@ -39,3 +39,16 @@ index ce86827024126c6b0d8462c811360057c298ec5b..d53307f9589d4487c220526b8e49b6c7 StringVector* const args, StringVector* const exec_args, StringVector* const v8_args, OptionsType* const options, OptionEnvvarSettings required_env_settings, StringVector* const errors); +diff --git a/src/node_options.cc b/src/node_options.cc +index 01dddb979042c098326a8b1ff37397642733f49b..f91a23c1d7ee8a141d349c486b7520c175094b8b 100644 +--- a/src/node_options.cc ++++ b/src/node_options.cc +@@ -237,7 +237,7 @@ const EnvironmentOptionsParser _eop_instance{_dop_instance}; + + // This Parse is not dead code. It is used by embedders (e.g., Electron). + template <> +-void Parse( ++void NODE_EXTERN Parse( + StringVector* const args, StringVector* const exec_args, + StringVector* const v8_args, + DebugOptions* const options,