mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: modernize-use-nodiscard clang-tidy warnings (32-x-y backport) (#44846)

Browse source 
fix: modernize-use-nodiscard clang-tidy warnings (#44808)
This commit is contained in:
Charles Kerr 2024-11-27 12:42:14 -06:00 committed by GitHub
parent d1639ccb79
commit 10e0ce0692
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/electron_permission_manager.cc
View file

@ -85,7 +85,7 @@ class ElectronPermissionManager::PendingRequest {
return content::RenderFrameHost::FromID(render_frame_host_id_); return content::RenderFrameHost::FromID(render_frame_host_id_);
} }
bool IsComplete() const { return remaining_results_ == 0; } [[nodiscard]] bool IsComplete() const { return remaining_results_ == 0; }
void RunCallback() { void RunCallback() {
if (!callback_.is_null()) { if (!callback_.is_null()) {

9
shell/browser/osr/osr_render_widget_host_view.cc
View file

@ -135,15 +135,16 @@ class ElectronDelegatedFrameHostClient
ElectronDelegatedFrameHostClient& operator=( ElectronDelegatedFrameHostClient& operator=(
const ElectronDelegatedFrameHostClient&) = delete; const ElectronDelegatedFrameHostClient&) = delete;
ui::Layer* DelegatedFrameHostGetLayer() const override { // content::DelegatedFrameHostClient
[[nodiscard]] ui::Layer* DelegatedFrameHostGetLayer() const override {
return view_->root_layer(); return view_->root_layer();
} }
bool DelegatedFrameHostIsVisible() const override { [[nodiscard]] bool DelegatedFrameHostIsVisible() const override {
return view_->IsShowing(); return view_->IsShowing();
} }
SkColor DelegatedFrameHostGetGutterColor() const override { [[nodiscard]] SkColor DelegatedFrameHostGetGutterColor() const override {
if (view_->render_widget_host()->delegate() && if (view_->render_widget_host()->delegate() &&
view_->render_widget_host()->delegate()->IsFullscreen()) { view_->render_widget_host()->delegate()->IsFullscreen()) {
return SK_ColorWHITE; return SK_ColorWHITE;
@ -156,7 +157,7 @@ class ElectronDelegatedFrameHostClient
view_->render_widget_host()->DidProcessFrame(frame_token, activation_time); view_->render_widget_host()->DidProcessFrame(frame_token, activation_time);
} }
float GetDeviceScaleFactor() const override { [[nodiscard]] float GetDeviceScaleFactor() const override {
return view_->GetDeviceScaleFactor(); return view_->GetDeviceScaleFactor();
} }

2
shell/common/api/electron_api_url_loader.cc
View file

@ -140,7 +140,7 @@ class BufferDataSource : public mojo::DataPipeProducer::DataSource {
private: private:
// mojo::DataPipeProducer::DataSource: // mojo::DataPipeProducer::DataSource:
uint64_t GetLength() const override { return buffer_.size(); } [[nodiscard]] uint64_t GetLength() const override { return buffer_.size(); }
ReadResult Read(uint64_t offset, base::span<char> buffer) override { ReadResult Read(uint64_t offset, base::span<char> buffer) override {
ReadResult result; ReadResult result;
if (offset <= buffer_.size()) { if (offset <= buffer_.size()) {

6
shell/common/extensions/electron_extensions_client.cc
View file

@ -39,12 +39,12 @@ class ElectronPermissionMessageProvider
const ElectronPermissionMessageProvider&) = delete; const ElectronPermissionMessageProvider&) = delete;
// PermissionMessageProvider implementation. // PermissionMessageProvider implementation.
extensions::PermissionMessages GetPermissionMessages( [[nodiscard]] extensions::PermissionMessages GetPermissionMessages(
const extensions::PermissionIDSet& permissions) const override { const extensions::PermissionIDSet& permissions) const override {
return extensions::PermissionMessages(); return extensions::PermissionMessages();
} }
bool IsPrivilegeIncrease( [[nodiscard]] bool IsPrivilegeIncrease(
const extensions::PermissionSet& granted_permissions, const extensions::PermissionSet& granted_permissions,
const extensions::PermissionSet& requested_permissions, const extensions::PermissionSet& requested_permissions,
extensions::Manifest::Type extension_type) const override { extensions::Manifest::Type extension_type) const override {
@ -53,7 +53,7 @@ class ElectronPermissionMessageProvider
return false; return false;
} }
extensions::PermissionIDSet GetAllPermissionIDs( [[nodiscard]] extensions::PermissionIDSet GetAllPermissionIDs(
const extensions::PermissionSet& permissions, const extensions::PermissionSet& permissions,
extensions::Manifest::Type extension_type) const override { extensions::Manifest::Type extension_type) const override {
return extensions::PermissionIDSet(); return extensions::PermissionIDSet();

2
shell/common/gin_helper/callback.cc
View file

@ -88,7 +88,7 @@ class RefCountedGlobal
RefCountedGlobal(v8::Isolate* isolate, v8::Local<v8::Value> value) RefCountedGlobal(v8::Isolate* isolate, v8::Local<v8::Value> value)
: handle_(isolate, value.As<T>()) {} : handle_(isolate, value.As<T>()) {}
bool IsAlive() const { return !handle_.IsEmpty(); } [[nodiscard]] bool IsAlive() const { return !handle_.IsEmpty(); }
v8::Local<T> NewHandle(v8::Isolate* isolate) const { v8::Local<T> NewHandle(v8::Isolate* isolate) const {
return v8::Local<T>::New(isolate, handle_); return v8::Local<T>::New(isolate, handle_);

2
shell/common/heap_snapshot.cc
View file

@ -18,7 +18,7 @@ class HeapSnapshotOutputStream : public v8::OutputStream {
DCHECK(file_); DCHECK(file_);
} }
bool IsComplete() const { return is_complete_; } [[nodiscard]] bool IsComplete() const { return is_complete_; }
// v8::OutputStream // v8::OutputStream
int GetChunkSize() override { return 65536; } int GetChunkSize() override { return 65536; }

2
shell/renderer/api/electron_api_spell_check_client.cc
View file

@ -57,7 +57,7 @@ class SpellCheckClient::SpellcheckRequest {
SpellcheckRequest& operator=(const SpellcheckRequest&) = delete; SpellcheckRequest& operator=(const SpellcheckRequest&) = delete;
~SpellcheckRequest() = default; ~SpellcheckRequest() = default;
const std::u16string& text() const { return text_; } [[nodiscard]] const std::u16string& text() const { return text_; }
blink::WebTextCheckingCompletion* completion() { return completion_.get(); } blink::WebTextCheckingCompletion* completion() { return completion_.get(); }
std::vector<Word>& wordlist() { return word_list_; } std::vector<Word>& wordlist() { return word_list_; }

2
shell/renderer/renderer_client_base.cc
View file

@ -131,7 +131,7 @@ class ChromePdfInternalPluginDelegate final
~ChromePdfInternalPluginDelegate() override = default; ~ChromePdfInternalPluginDelegate() override = default;
// `pdf::PdfInternalPluginDelegate`: // `pdf::PdfInternalPluginDelegate`:
bool IsAllowedOrigin(const url::Origin& origin) const override { [[nodiscard]] bool IsAllowedOrigin(const url::Origin& origin) const override {
return origin.scheme() == extensions::kExtensionScheme && return origin.scheme() == extensions::kExtensionScheme &&
origin.host() == extension_misc::kPdfExtensionId; origin.host() == extension_misc::kPdfExtensionId;
} }