mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: modernize-use-nodiscard clang-tidy warnings (32-x-y backport) (#44846)

Browse source 
fix: modernize-use-nodiscard clang-tidy warnings (#44808)
This commit is contained in:
Charles Kerr 2024-11-27 12:42:14 -06:00 • committed by GitHub
parent d1639ccb79
commit 10e0ce0692
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/gin_helper/callback.cc
View file

@ -88,7 +88,7 @@ class RefCountedGlobal
RefCountedGlobal(v8::Isolate* isolate, v8::Local<v8::Value> value)
: handle_(isolate, value.As<T>()) {}
bool IsAlive() const { return !handle_.IsEmpty(); }
[[nodiscard]] bool IsAlive() const { return !handle_.IsEmpty(); }
v8::Local<T> NewHandle(v8::Isolate* isolate) const {
return v8::Local<T>::New(isolate, handle_);