mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: modernize-use-nodiscard clang-tidy warnings (32-x-y backport) (#44846)

Browse source 
fix: modernize-use-nodiscard clang-tidy warnings (#44808)
This commit is contained in:
Charles Kerr 2024-11-27 12:42:14 -06:00 • committed by GitHub
parent d1639ccb79
commit 10e0ce0692
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/api/electron_api_url_loader.cc
View file

@ -140,7 +140,7 @@ class BufferDataSource : public mojo::DataPipeProducer::DataSource {
private:
// mojo::DataPipeProducer::DataSource:
uint64_t GetLength() const override { return buffer_.size(); }
[[nodiscard]] uint64_t GetLength() const override { return buffer_.size(); }
ReadResult Read(uint64_t offset, base::span<char> buffer) override {
ReadResult result;
if (offset <= buffer_.size()) {

6
shell/common/extensions/electron_extensions_client.cc
View file

@ -39,12 +39,12 @@ class ElectronPermissionMessageProvider
const ElectronPermissionMessageProvider&) = delete;
// PermissionMessageProvider implementation.
extensions::PermissionMessages GetPermissionMessages(
[[nodiscard]] extensions::PermissionMessages GetPermissionMessages(
const extensions::PermissionIDSet& permissions) const override {
return extensions::PermissionMessages();
}
bool IsPrivilegeIncrease(
[[nodiscard]] bool IsPrivilegeIncrease(
const extensions::PermissionSet& granted_permissions,
const extensions::PermissionSet& requested_permissions,
extensions::Manifest::Type extension_type) const override {
@ -53,7 +53,7 @@ class ElectronPermissionMessageProvider
return false;
}
extensions::PermissionIDSet GetAllPermissionIDs(
[[nodiscard]] extensions::PermissionIDSet GetAllPermissionIDs(
const extensions::PermissionSet& permissions,
extensions::Manifest::Type extension_type) const override {
return extensions::PermissionIDSet();

2
shell/common/gin_helper/callback.cc
View file

@ -88,7 +88,7 @@ class RefCountedGlobal
RefCountedGlobal(v8::Isolate* isolate, v8::Local<v8::Value> value)
: handle_(isolate, value.As<T>()) {}
bool IsAlive() const { return !handle_.IsEmpty(); }
[[nodiscard]] bool IsAlive() const { return !handle_.IsEmpty(); }
v8::Local<T> NewHandle(v8::Isolate* isolate) const {
return v8::Local<T>::New(isolate, handle_);

2
shell/common/heap_snapshot.cc
View file

@ -18,7 +18,7 @@ class HeapSnapshotOutputStream : public v8::OutputStream {
DCHECK(file_);
}
bool IsComplete() const { return is_complete_; }
[[nodiscard]] bool IsComplete() const { return is_complete_; }
// v8::OutputStream
int GetChunkSize() override { return 65536; }