mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: modernize-use-nodiscard clang-tidy warnings (32-x-y backport) (#44846)

Browse source 
fix: modernize-use-nodiscard clang-tidy warnings (#44808)
This commit is contained in:
Charles Kerr 2024-11-27 12:42:14 -06:00 • committed by GitHub
parent d1639ccb79
commit 10e0ce0692
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/electron_permission_manager.cc
View file

@ -85,7 +85,7 @@ class ElectronPermissionManager::PendingRequest {
return content::RenderFrameHost::FromID(render_frame_host_id_);
}
bool IsComplete() const { return remaining_results_ == 0; }
[[nodiscard]] bool IsComplete() const { return remaining_results_ == 0; }
void RunCallback() {
if (!callback_.is_null()) {

9
shell/browser/osr/osr_render_widget_host_view.cc
View file

@ -135,15 +135,16 @@ class ElectronDelegatedFrameHostClient
ElectronDelegatedFrameHostClient& operator=(
const ElectronDelegatedFrameHostClient&) = delete;
ui::Layer* DelegatedFrameHostGetLayer() const override {
// content::DelegatedFrameHostClient
[[nodiscard]] ui::Layer* DelegatedFrameHostGetLayer() const override {
return view_->root_layer();
}
bool DelegatedFrameHostIsVisible() const override {
[[nodiscard]] bool DelegatedFrameHostIsVisible() const override {
return view_->IsShowing();
}
SkColor DelegatedFrameHostGetGutterColor() const override {
[[nodiscard]] SkColor DelegatedFrameHostGetGutterColor() const override {
if (view_->render_widget_host()->delegate() &&
view_->render_widget_host()->delegate()->IsFullscreen()) {
return SK_ColorWHITE;
@ -156,7 +157,7 @@ class ElectronDelegatedFrameHostClient
view_->render_widget_host()->DidProcessFrame(frame_token, activation_time);
}
float GetDeviceScaleFactor() const override {
[[nodiscard]] float GetDeviceScaleFactor() const override {
return view_->GetDeviceScaleFactor();
}