mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Mark atom-shell version as deprecated

Browse source
This commit is contained in:
Kevin Sawicki 2016-09-16 15:57:07 -07:00
parent d4b204799d
commit 1072519488
6 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/common/api/atom_bindings.cc
View file

@ -117,8 +117,10 @@ void AtomBindings::BindTo(v8::Isolate* isolate,
mate::Dictionary versions;
if (dict.Get("versions", &versions)) {
versions.Set(ATOM_PROJECT_NAME, ATOM_VERSION_STRING);
versions.Set("atom-shell", ATOM_VERSION_STRING); // For compatibility.
versions.Set("chrome", CHROME_VERSION_STRING);
// TODO(kevinsawicki): Remove in 2.0
versions.Set("atom-shell", ATOM_VERSION_STRING);
}
}

2
atom/common/api/atom_bindings.h
View file

@ -24,7 +24,7 @@ class AtomBindings {
virtual ~AtomBindings();
// Add process.atomBinding function, which behaves like process.binding but
// load native code from atom-shell instead.
// load native code from Electron instead.
void BindTo(v8::Isolate* isolate, v8::Local<v8::Object> process);
private: