mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #5882 from electron/felix-extension-warning-2

Browse source 
Log a warning if an extension's manifest cannot be parsed
This commit is contained in:
Cheng Zhao 2016-06-06 06:20:02 +00:00 • committed by GitHub
commit 1066c1acaf
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/browser/chrome-extension.js
View file

@ -20,7 +20,15 @@ const generateExtensionIdFromName = function (name) {
// Create or get manifest object from |srcDirectory|. // Create or get manifest object from |srcDirectory|.
const getManifestFromPath = function (srcDirectory) { const getManifestFromPath = function (srcDirectory) {
const manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json'))) let manifest
try {
manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json')))
} catch (err) {
console.warn(`Attempted to load extension from ${srcDirectory}, but parsing the manifest failed.`)
console.warn('Error encountered:', err)
}
if (!manifestNameMap[manifest.name]) { if (!manifestNameMap[manifest.name]) {
const extensionId = generateExtensionIdFromName(manifest.name) const extensionId = generateExtensionIdFromName(manifest.name)
console.log(extensionId) console.log(extensionId)