mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: migrate to View::AddChildView(std::unique_ptr<ui::View*>) (#46541)

Browse source 
* refactor: use AddChildView(std::unique_ptr<View>) in OpaqueFrameView::CreateButton()

Xref: https://issues.chromium.org/issues/40485510

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use AddChildView(std::unique_ptr<View>) in MenuBar::RebuildChildren()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux labels

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use AddChildView(std::unique_ptr<View>) for ClientFrameViewLinux buttons

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use AddChildView(std::unique_ptr<View>) in AutofillPopupView

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use AddChildViewRaw() to flag the edge cases that we still need to fix

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: use west coast const for consistency

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-04-07 13:29:37 -05:00 • committed by GitHub
parent 2dd4b77ae0
commit 1046842f73
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 30 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/ui/views/client_frame_view_linux.h
View file

@ -95,7 +95,7 @@ class ClientFrameViewLinux : public FramelessView,
void (views::Widget::*callback)();
int accessibility_id;
int hit_test_id;
RAW_PTR_EXCLUSION views::ImageButton* button{nullptr};
raw_ptr<views::ImageButton> button = {};
};
struct ThemeValues {
@ -132,7 +132,7 @@ class ClientFrameViewLinux : public FramelessView,
raw_ptr<ui::NativeTheme> theme_;
ThemeValues theme_values_;
RAW_PTR_EXCLUSION views::Label* title_;
raw_ptr<views::Label> title_;
std::unique_ptr<ui::NavButtonProvider> nav_button_provider_;
std::array<NavButton, kNavButtonCount> nav_buttons_;