Do not create DIR_USER_DATA on IO thread

It would slowdown the startup time of apps since we have wait for two
message posts between threads.

atom/browser/browser.cc

@@ -14,31 +14,12 @@
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
-#include "base/task_scheduler/post_task.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "brightray/browser/brightray_paths.h"
-#include "content/public/browser/browser_thread.h"
 
 namespace atom {
 
-namespace {
-
-bool CreateUserDataDirectory() {
-  // Make sure the userData directory is created.
-  base::FilePath user_data;
-  bool success = false;
-  if (PathService::Get(brightray::DIR_USER_DATA, &user_data))
-    success = base::CreateDirectoryAndGetError(user_data, nullptr);
-
-  if (!success) {
-    NOTREACHED() << "Failed to create directory '" << user_data.value() << "'";
-  }
-
-  return success;
-}
-
-}  // namespace
-
 Browser::Browser()
     : is_quiting_(false),
       is_exiting_(false),
@@ -170,25 +151,15 @@ void Browser::WillFinishLaunching() {
 }
 
 void Browser::DidFinishLaunching(const base::DictionaryValue& launch_info) {
-  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  // Make sure the userData directory is created.
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
+  base::FilePath user_data;
+  if (PathService::Get(brightray::DIR_USER_DATA, &user_data))
+    base::CreateDirectoryAndGetError(user_data, nullptr);
 
-  base::PostTaskWithTraitsAndReplyWithResult(
+  is_ready_ = true;
-      FROM_HERE, {base::MayBlock(), base::TaskPriority::USER_BLOCKING},
+  for (BrowserObserver& observer : observers_)
-      base::Bind(&CreateUserDataDirectory),
+    observer.OnFinishLaunching(launch_info);
-      base::Bind(&Browser::OnUserDataDirectoryCreated, base::Unretained(this),
-                 launch_info));
-}
-
-void Browser::OnUserDataDirectoryCreated(
-    const base::DictionaryValue& launch_info,
-    bool success) {
-  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-
-  if (success) {
-    is_ready_ = true;
-    for (BrowserObserver& observer : observers_)
-      observer.OnFinishLaunching(launch_info);
-  }
 }
 
 void Browser::OnAccessibilitySupportChanged() {

atom/browser/browser.h

@@ -258,11 +258,6 @@ class Browser : public WindowListObserver {
   void OnWindowCloseCancelled(NativeWindow* window) override;
   void OnWindowAllClosed() override;
 
-  // Called after attempting to create the user data directory
-  // for the app.
-  void OnUserDataDirectoryCreated(const base::DictionaryValue& launch_info,
-                                  bool success);
-
   // Observers of the browser.
   base::ObserverList<BrowserObserver> observers_;
 

chromium_src/chrome/browser/process_singleton_posix.cc

@@ -77,7 +77,6 @@
 #include "base/rand_util.h"
 #include "base/sequenced_task_runner_helpers.h"
 #include "base/single_thread_task_runner.h"
-#include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"