fix: [extensions] load extensions on the IO thread (#21811)

This commit is contained in:
Jeremy Apthorp 2020-01-21 09:43:18 -08:00 committed by GitHub
parent acb5b75057
commit 100a85f93a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 46 additions and 35 deletions

View file

@ -6,6 +6,7 @@
#include <memory>
#include <string>
#include <utility>
#include "base/bind.h"
#include "base/files/file_path.h"
@ -43,14 +44,10 @@ AtomExtensionSystem::AtomExtensionSystem(BrowserContext* browser_context)
AtomExtensionSystem::~AtomExtensionSystem() = default;
const Extension* AtomExtensionSystem::LoadExtension(
const base::FilePath& extension_dir) {
return extension_loader_->LoadExtension(extension_dir);
}
const Extension* AtomExtensionSystem::LoadApp(const base::FilePath& app_dir) {
NOTIMPLEMENTED() << "Attempted to load platform app in Electron";
return nullptr;
void AtomExtensionSystem::LoadExtension(
const base::FilePath& extension_dir,
base::OnceCallback<void(const Extension*)> loaded) {
extension_loader_->LoadExtension(extension_dir, std::move(loaded));
}
void AtomExtensionSystem::FinishInitialization() {