test: ensure sender-pid
hint is set in Linux notifications (#43949)
test: expect a `sender-pid` hint in Linux notifications. This PR ensures that the `sender-pid` hint is set for new notifications. It also updates the spec to confirm that DBus receives the hint and that it has the correct value. This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05). Starting with that version, libnotify started injecting `sender-pid` if not provided by the client. So our tests received a slightly different DBus payload depending on what version of libnotify was installed, causing our deep-equals tests to fail. By always providing and testing the `sender-pid` hint, our behavior and tests should be consistent across distros. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
parent
134176a1d1
commit
0ffafbc295
3 changed files with 7 additions and 0 deletions
|
@ -118,6 +118,7 @@ ifdescribe(!skip)('Notification module (dbus)', () => {
|
|||
hints: {
|
||||
append: 'true',
|
||||
'desktop-entry': appName,
|
||||
'sender-pid': process.pid,
|
||||
urgency: 1
|
||||
}
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue