mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Guarding webview attributes against polluted Object.prototypes

Browse source 
Ran into an error with the buildParams function breaking when using a JavaScript library that modified the Object.prototype, this small fix resolves the issue.
This commit is contained in:
Kirk Ouimet 2015-06-09 16:17:00 -07:00
parent f91a81fe77
commit 0fef09281b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/renderer/lib/web-view/web-view.coffee
View file

@ -173,7 +173,7 @@ class WebViewImpl
params = params =
instanceId: @viewInstanceId instanceId: @viewInstanceId
userAgentOverride: @userAgentOverride userAgentOverride: @userAgentOverride
for attributeName, attribute of @attributes for own attributeName, attribute of @attributes
params[attributeName] = attribute.getValue() params[attributeName] = attribute.getValue()
# When the WebView is not participating in layout (display:none) # When the WebView is not participating in layout (display:none)
# then getBoundingClientRect() would report a width and height of 0. # then getBoundingClientRect() would report a width and height of 0.