mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #3441 from brenca/master

Browse source 
Fixing memory leak in FrameSubscriber
This commit is contained in:
Cheng Zhao 2015-11-16 16:03:58 +08:00
commit 0f89573719
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/api/frame_subscriber.cc
View file

@ -38,6 +38,9 @@ void FrameSubscriber::OnFrameDelivered(
if (!result) if (!result)
return; return;
v8::Locker locker(isolate_);
v8::HandleScope handle_scope(isolate_);
gfx::Rect rect = frame->visible_rect(); gfx::Rect rect = frame->visible_rect();
size_t rgb_arr_size = rect.width() * rect.height() * 4; size_t rgb_arr_size = rect.width() * rect.height() * 4;
v8::MaybeLocal<v8::Object> buffer = node::Buffer::New(isolate_, rgb_arr_size); v8::MaybeLocal<v8::Object> buffer = node::Buffer::New(isolate_, rgb_arr_size);
@ -56,8 +59,6 @@ void FrameSubscriber::OnFrameDelivered(
rect.width() * 4, rect.width() * 4,
media::YV12); media::YV12);
v8::Locker locker(isolate_);
v8::HandleScope handle_scope(isolate_);
callback_.Run(buffer.ToLocalChecked()); callback_.Run(buffer.ToLocalChecked());
} }