mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: return null when passing empty menu templates (#23364)

Browse source
This commit is contained in:
shelley vohr 2020-05-04 08:19:21 -07:00 • committed by GitHub
parent 59c1c12e0b
commit 0f0cc51b35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec-main/api-menu-spec.ts
View file

@ -93,12 +93,6 @@ describe('Menu module', function () {
}).to.throw(/Invalid template for MenuItem: must have at least one of label, role or type/);
});
it('throws when an empty array is passed as a template', () => {
expect(() => {
Menu.buildFromTemplate([]);
}).to.throw(/Invalid template for Menu: Menu template must be an non-empty array/);
});
it('throws when an non-array is passed as a template', () => {
expect(() => {
Menu.buildFromTemplate('hello' as any);