mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: return null when passing empty menu templates (#23364)

Browse source
This commit is contained in:
shelley vohr 2020-05-04 08:19:21 -07:00 • committed by GitHub
commit 0f0cc51b35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/browser/api/menu.js
View file

@ -173,11 +173,9 @@ Menu.setApplicationMenu = function (menu) {
}
};
Menu.buildFromTemplate = function (template, isSubmenu = false) {
Menu.buildFromTemplate = function (template) {
if (!Array.isArray(template)) {
throw new TypeError('Invalid template for Menu: Menu template must be an array');
} else if (!isSubmenu && template.length === 0) {
throw new TypeError('Invalid template for Menu: Menu template must be an non-empty array');
}
if (!areValidTemplateItems(template)) {