mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: return null when passing empty menu templates (#23364)

Browse source
This commit is contained in:
shelley vohr 2020-05-04 08:19:21 -07:00 • committed by GitHub
parent 59c1c12e0b
commit 0f0cc51b35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/browser/api/menu-item.js
View file

@ -16,7 +16,7 @@ const MenuItem = function (options) {
}
this.submenu = this.submenu || roles.getDefaultSubmenu(this.role);
if (this.submenu != null && this.submenu.constructor !== Menu) {
this.submenu = Menu.buildFromTemplate(this.submenu, true);
this.submenu = Menu.buildFromTemplate(this.submenu);
}
if (this.type == null && this.submenu != null) {
this.type = 'submenu';