mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: narrow scope of afterEach in remote to tests that need it (#18447)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-05-28 14:07:48 -07:00 • committed by GitHub
parent 96b32a814c
commit 0e2dedaf4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spec/api-remote-spec.js
View file

@ -23,10 +23,6 @@ const comparePaths = (path1, path2) => {
describe('remote module', () => { describe('remote module', () => {
const fixtures = path.join(__dirname, 'fixtures') const fixtures = path.join(__dirname, 'fixtures')
let w = null
afterEach(() => closeWindow(w).then(() => { w = null }))
describe('remote.getGlobal filtering', () => { describe('remote.getGlobal filtering', () => {
it('can return custom values', () => { it('can return custom values', () => {
ipcRenderer.send('handle-next-remote-get-global', { test: 'Hello World!' }) ipcRenderer.send('handle-next-remote-get-global', { test: 'Hello World!' })
@ -552,6 +548,9 @@ describe('remote module', () => {
}) })
describe('remote function in renderer', () => { describe('remote function in renderer', () => {
let w = null
afterEach(() => closeWindow(w).then(() => { w = null }))
afterEach(() => { afterEach(() => {
ipcMain.removeAllListeners('done') ipcMain.removeAllListeners('done')
}) })