mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h (32-x-y) (#44747)

Browse source 
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h (#44705)

fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]

refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
This commit is contained in:
Charles Kerr 2024-11-22 03:22:27 -06:00 • committed by GitHub
parent 71240835ba
commit 0e001fc45a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 28 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/ui/views/autofill_popup_view.cc
View file

@ -10,7 +10,9 @@
#include "base/functional/bind.h"
#include "base/i18n/rtl.h"
#include "cc/paint/skia_paint_canvas.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_view_host.h"
#include "shell/browser/ui/autofill_popup.h"
#include "ui/accessibility/ax_enums.mojom.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/color/color_provider.h"

9
shell/browser/ui/views/autofill_popup_view.h
View file

@ -8,8 +8,6 @@
#include <memory>
#include <optional>
#include "shell/browser/ui/autofill_popup.h"
#include "base/memory/raw_ptr.h"
#include "components/input/native_web_keyboard_event.h"
#include "content/public/browser/render_widget_host.h"
@ -25,11 +23,8 @@
namespace electron {
const int kPopupBorderThickness = 1;
const int kSmallerFontSizeDelta = -1;
const int kEndPadding = 8;
const int kNamePadding = 15;
const int kRowHeight = 24;
constexpr int kPopupBorderThickness = 1;
constexpr int kEndPadding = 8;
class AutofillPopup;