From 0d8c4dde9798944303a7b0c2466ce550cf8b2705 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Sun, 14 Apr 2013 17:33:44 +0800 Subject: [PATCH] :lipstick: for cpplint. --- app/atom_library_main.h | 4 +--- browser/api/atom_extensions.cc | 5 ++--- browser/atom_browser_main_parts.h | 2 +- common/node_bindings.h | 3 ++- common/node_bindings_mac.mm | 4 ++-- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/app/atom_library_main.h b/app/atom_library_main.h index adbe25bda50c..b9aa32511b26 100644 --- a/app/atom_library_main.h +++ b/app/atom_library_main.h @@ -6,10 +6,8 @@ #define ATOM_APP_ATOM_LIBRARY_MAIN_ extern "C" { - -__attribute__ ((visibility ("default"))) +__attribute__((visibility("default"))) int AtomMain(int argc, const char* argv[]); - } #endif // ATOM_APP_ATOM_LIBRARY_MAIN_ diff --git a/browser/api/atom_extensions.cc b/browser/api/atom_extensions.cc index 0cb77796915e..b37b6f11c20a 100644 --- a/browser/api/atom_extensions.cc +++ b/browser/api/atom_extensions.cc @@ -29,10 +29,9 @@ namespace atom { #define NODE_EXT_LIST_ITEM NODE_EXT_STRING #define NODE_EXT_LIST_END NULL}; -#include "browser/api/atom_extensions.h" +#include "browser/api/atom_extensions.h" // NOLINT -node::node_module_struct* get_builtin_module(const char *name) -{ +node::node_module_struct* get_builtin_module(const char *name) { char buf[128]; node::node_module_struct *cur = NULL; snprintf(buf, sizeof(buf), "atom_%s", name); diff --git a/browser/atom_browser_main_parts.h b/browser/atom_browser_main_parts.h index 6e96aaa1d335..aa50ef7d7d22 100644 --- a/browser/atom_browser_main_parts.h +++ b/browser/atom_browser_main_parts.h @@ -20,7 +20,7 @@ class AtomBrowserMainParts : public brightray::BrowserMainParts { protected: virtual void PostEarlyInitialization() OVERRIDE; - virtual void PreMainMessageLoopStart() OVERRIDE; + virtual void PreMainMessageLoopStart() OVERRIDE; virtual void PreMainMessageLoopRun() OVERRIDE; private: diff --git a/common/node_bindings.h b/common/node_bindings.h index 9c9d4cadee32..2b684d8ee441 100644 --- a/common/node_bindings.h +++ b/common/node_bindings.h @@ -32,9 +32,10 @@ class NodeBindings { bool is_browser_; + private: DISALLOW_COPY_AND_ASSIGN(NodeBindings); }; -} // namespace at +} // namespace atom #endif // RAVE_COMMON_NODE_BINDINGS_ diff --git a/common/node_bindings_mac.mm b/common/node_bindings_mac.mm index cc203c02d185..78cdc6ad13c3 100644 --- a/common/node_bindings_mac.mm +++ b/common/node_bindings_mac.mm @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "node_bindings_mac.h" +#include "common/node_bindings_mac.h" #include "base/message_loop.h" #include "content/public/browser/browser_thread.h" @@ -76,7 +76,7 @@ void NodeBindingsMac::UvRunOnce() { // Deal with uv events. int r = uv_run(loop_, (uv_run_mode)(UV_RUN_ONCE | UV_RUN_NOWAIT)); if (r == 0 || loop_->stop_flag != 0) - MessageLoop::current()->QuitWhenIdle(); // Quit from uv. + MessageLoop::current()->QuitWhenIdle(); // Quit from uv. // Tell the worker thread to continue polling. uv_sem_post(&embed_sem_);