mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: modernize ListValue usage in permission manager (#34662)

Browse source
This commit is contained in:
Jeremy Rose 2022-06-29 10:09:48 -07:00 • committed by GitHub
parent 4ddd03b1b3
commit 0d4e417594
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 54 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/web_contents_permission_helper.h
View file

@ -59,10 +59,10 @@ class WebContentsPermissionHelper
void RequestPermission(blink::PermissionType permission,
base::OnceCallback<void(bool)> callback,
bool user_gesture = false,
const base::DictionaryValue* details = nullptr);
base::Value::Dict details = {});
bool CheckPermission(blink::PermissionType permission,
const base::DictionaryValue* details) const;
base::Value::Dict details) const;
// TODO(clavin): refactor to use the WebContents provided by the
// WebContentsUserData base class instead of storing a duplicate ref