mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix issues and deprecate the old prop

Browse source
This commit is contained in:
Samuel Attard 2016-11-08 11:18:49 +11:00 • committed by Kevin Sawicki
parent 0b9530efd7
commit 0d1804b2a0
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
atom/common/crash_reporter/crash_reporter.h
View file

@ -33,6 +33,8 @@ class CrashReporter {
virtual std::vector<CrashReporter::UploadReportResult> GetUploadedReports( virtual std::vector<CrashReporter::UploadReportResult> GetUploadedReports(
const base::FilePath& crashes_dir); const base::FilePath& crashes_dir);
virtual void SetShouldUpload();
protected: protected:
CrashReporter(); CrashReporter();
virtual ~CrashReporter(); virtual ~CrashReporter();
@ -46,8 +48,6 @@ class CrashReporter {
bool skip_system_crash_handler); bool skip_system_crash_handler);
virtual void SetUploadParameters(); virtual void SetUploadParameters();
virtual void SetShouldUpload();
StringMap upload_parameters_; StringMap upload_parameters_;
bool is_browser_; bool is_browser_;

4
lib/common/api/crash-reporter.js
View file

@ -18,6 +18,10 @@ class CrashReporter {
if (autoSubmit == null && shouldUpload == null) { if (autoSubmit == null && shouldUpload == null) {
shouldUpload = true shouldUpload = true
} else { } else {
if (typeof autoSubmit !== 'undefined') {
// TODO: Remove depreceated property in 2.0.0
console.warn('The "autoSubmit" attribute on electron.crashReporter is depreceated. Please use "shouldUpload" instead.')
}
shouldUpload = shouldUpload || autoSubmit shouldUpload = shouldUpload || autoSubmit
} }
if (ignoreSystemCrashHandler == null) { if (ignoreSystemCrashHandler == null) {