mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: add microtask runner and fix promise test (#15071)

Browse source 
* fix: Promise resolution and unit test

* Update to use microtask runner

* Address review
This commit is contained in:
Nitish Sakhawalkar 2018-10-15 08:26:47 -07:00 • committed by Samuel Attard
parent 89bf71e580
commit 0c711f690e
13 changed files with 90 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/api-app-spec.js
View file

@ -852,10 +852,9 @@ describe('app module', () => {
await verifyBasicGPUInfo(gpuInfo)
})
// FIXME: this broke with the M69 upgrade.
xit('succeeds with complete GPUInfo', async () => {
it('succeeds with complete GPUInfo', async () => {
const completeInfo = await getGPUInfo('complete')
if (process.platform === 'linux' || process.platform === 'darwin') {
if (process.platform === 'linux') {
// For linux and macOS complete info is same as basic info
await verifyBasicGPUInfo(completeInfo)
const basicInfo = await getGPUInfo('basic')
@ -872,11 +871,8 @@ describe('app module', () => {
it('fails for invalid info_type', () => {
const invalidType = 'invalid'
const errorMessage =
`app.getGPUInfo() didn't fail for the "${invalidType}" info type`
return app.getGPUInfo(invalidType).then(
() => Promise.reject(new Error(errorMessage)),
() => Promise.resolve())
const expectedErrorMessage = "Invalid info type. Use 'basic' or 'complete'"
return expect(app.getGPUInfo(invalidType)).to.eventually.be.rejectedWith(expectedErrorMessage)
})
})