mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: remove lingering data when notifications autodismiss on Windows 7 (#18401)

Browse source
This commit is contained in:
Robert Säll 2019-06-12 01:39:25 +02:00 • committed by Cheng Zhao
parent 0e3ab7c128
commit 0bf83b7183
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/notifications/win/win32_notification.cc
View file

@ -47,8 +47,12 @@ void Win32Notification::Show(const NotificationOptions& options) {
if (existing) {
existing->tag_.clear();
this->notification_ref_ = std::move(existing->notification_ref_);
this->notification_ref_.Set(options.title, options.msg, image);
// Need to remove the entry in the notifications set that
// NotificationPresenter is holding
existing->Destroy();
} else {
this->notification_ref_ =
presenter->AddNotification(options.title, options.msg, image);