mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

docs: mark skipTaskbar as unsupported on Linux (#33226)

Browse source 
Fixes #33124.
This commit is contained in:
Charles Kerr 2022-03-22 01:12:20 -05:00 • committed by GitHub
parent f5112632a3
commit 0af2b8de73
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/api/browser-window.md
View file

@ -186,8 +186,8 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
mode. On macOS, also whether the maximize/zoom button should toggle full mode. On macOS, also whether the maximize/zoom button should toggle full
screen mode or maximize window. Default is `true`. screen mode or maximize window. Default is `true`.
* `simpleFullscreen` boolean (optional) - Use pre-Lion fullscreen on macOS. Default is `false`. * `simpleFullscreen` boolean (optional) - Use pre-Lion fullscreen on macOS. Default is `false`.
* `skipTaskbar` boolean (optional) - Whether to show the window in taskbar. Default is * `skipTaskbar` boolean (optional) _macOS_ _Windows_ - Whether to show the window in taskbar.
`false`. Default is `false`.
* `kiosk` boolean (optional) - Whether the window is in kiosk mode. Default is `false`. * `kiosk` boolean (optional) - Whether the window is in kiosk mode. Default is `false`.
* `title` string (optional) - Default window title. Default is `"Electron"`. If the HTML tag `<title>` is defined in the HTML file loaded by `loadURL()`, this property will be ignored. * `title` string (optional) - Default window title. Default is `"Electron"`. If the HTML tag `<title>` is defined in the HTML file loaded by `loadURL()`, this property will be ignored.
* `icon` ([NativeImage](native-image.md) | string) (optional) - The window icon. On Windows it is * `icon` ([NativeImage](native-image.md) | string) (optional) - The window icon. On Windows it is

13
docs/breaking-changes.md
View file

@ -27,9 +27,20 @@ preload scripts _do_ depend on Node, either refactor them to remove Node usage
from the renderer, or explicitly specify `sandbox: false` for the relevant from the renderer, or explicitly specify `sandbox: false` for the relevant
renderers. renderers.
### Removed: `skipTaskbar` on Linux
See `skipTaskbar` discussion in 19.0 below. This feature is not available on
Wayland. Since most modern Linux desktops are transitioning to Wayland, this
feature will be removed for Linux.
## Planned Breaking API Changes (19.0) ## Planned Breaking API Changes (19.0)
*None (yet)* ### Unsupported: `skipTaskbar` on Linux
On X11, `skipTaskbar` sends a `_NET_WM_STATE_SKIP_TASKBAR` message to the X11
window manager. There is not a direct equivalent for Wayland, and the known
workarounds have unacceptable tradeoffs (e.g. Window.is_skip_taskbar in GNOME
requires unsafe mode), so Electron is unable to support this feature on Linux.
## Planned Breaking API Changes (18.0) ## Planned Breaking API Changes (18.0)

1
shell/browser/native_window_views.cc
View file

@ -291,6 +291,7 @@ NativeWindowViews::NativeWindowViews(const gin_helper::Dictionary& options,
#endif #endif
#if defined(USE_X11) #if defined(USE_X11)
// TODO(ckerr): remove in Electron v20.0.0
// Before the window is mapped the SetWMSpecState can not work, so we have // Before the window is mapped the SetWMSpecState can not work, so we have
// to manually set the _NET_WM_STATE. // to manually set the _NET_WM_STATE.
std::vector<x11::Atom> state_atom_list; std::vector<x11::Atom> state_atom_list;