refactor: pass base::Value by value in JS API implementations (#20809)
* refactor: move the arg instead of const reference it * refactor: avoid unnecessary copies of base::Value in arg * refactor: pass-by-value in dict_util * refactor: avoid unnecessary reference
This commit is contained in:
parent
c03ed6d3a1
commit
0ab9cc30d2
26 changed files with 108 additions and 144 deletions
|
@ -117,12 +117,14 @@ inline void dispatch_sync_main(dispatch_block_t block) {
|
|||
dispatch_sync_main(^{
|
||||
std::string activity_type(
|
||||
base::SysNSStringToUTF8(userActivity.activityType));
|
||||
std::unique_ptr<base::DictionaryValue> user_info =
|
||||
base::DictionaryValue user_info =
|
||||
electron::NSDictionaryToDictionaryValue(userActivity.userInfo);
|
||||
|
||||
electron::Browser* browser = electron::Browser::Get();
|
||||
shouldWait =
|
||||
browser->UpdateUserActivityState(activity_type, *user_info) ? YES : NO;
|
||||
browser->UpdateUserActivityState(activity_type, std::move(user_info))
|
||||
? YES
|
||||
: NO;
|
||||
});
|
||||
|
||||
if (shouldWait) {
|
||||
|
@ -144,11 +146,11 @@ inline void dispatch_sync_main(dispatch_block_t block) {
|
|||
dispatch_async(dispatch_get_main_queue(), ^{
|
||||
std::string activity_type(
|
||||
base::SysNSStringToUTF8(userActivity.activityType));
|
||||
std::unique_ptr<base::DictionaryValue> user_info =
|
||||
base::DictionaryValue user_info =
|
||||
electron::NSDictionaryToDictionaryValue(userActivity.userInfo);
|
||||
|
||||
electron::Browser* browser = electron::Browser::Get();
|
||||
browser->UserActivityWasContinued(activity_type, *user_info);
|
||||
browser->UserActivityWasContinued(activity_type, std::move(user_info));
|
||||
});
|
||||
[userActivity setNeedsSave:YES];
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue