Refactor as per @zcbenz comments
Also fix issue where we run the single instance callback *not* on the UI thread, this apparently results in a hung process.
This commit is contained in:
parent
ecbeb0d117
commit
0ab83b301d
7 changed files with 22 additions and 16 deletions
|
@ -74,8 +74,6 @@ class App : public AtomBrowserClient::Delegate,
|
|||
static void BuildPrototype(v8::Isolate* isolate,
|
||||
v8::Local<v8::FunctionTemplate> prototype);
|
||||
|
||||
static App* Get();
|
||||
|
||||
// Called when window with disposition needs to be created.
|
||||
void OnCreateWindow(
|
||||
const GURL& target_url,
|
||||
|
@ -101,7 +99,6 @@ class App : public AtomBrowserClient::Delegate,
|
|||
protected:
|
||||
explicit App(v8::Isolate* isolate);
|
||||
~App() override;
|
||||
static App* self_;
|
||||
|
||||
// BrowserObserver:
|
||||
void OnBeforeQuit(bool* prevent_default) override;
|
||||
|
@ -116,6 +113,7 @@ class App : public AtomBrowserClient::Delegate,
|
|||
void OnLogin(LoginHandler* login_handler,
|
||||
const base::DictionaryValue& request_details) override;
|
||||
void OnAccessibilitySupportChanged() override;
|
||||
void OnPreMainMessageLoopRun() override;
|
||||
#if defined(OS_MACOSX)
|
||||
void OnWillContinueUserActivity(
|
||||
bool* prevent_default,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue