From 0a5da83a1b8bb9316f4b171a0da72587080638d1 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 3 Apr 2025 17:51:37 -0500 Subject: [PATCH] perf: avoid redundant map lookup in `HidChooserContext::DeviceChanged()` (#46451) perf: avoid redundant map lookup in HidChooserContext::DeviceChanged() --- shell/browser/hid/hid_chooser_context.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/shell/browser/hid/hid_chooser_context.cc b/shell/browser/hid/hid_chooser_context.cc index 6e288fa19e54..4869f56eb8de 100644 --- a/shell/browser/hid/hid_chooser_context.cc +++ b/shell/browser/hid/hid_chooser_context.cc @@ -274,10 +274,11 @@ void HidChooserContext::DeviceRemoved(device::mojom::HidDeviceInfoPtr device) { void HidChooserContext::DeviceChanged(device::mojom::HidDeviceInfoPtr device) { DCHECK(device); - DCHECK(devices_.contains(device->guid)); // Update the device list. - devices_[device->guid] = device->Clone(); + auto& mapped = devices_[device->guid]; + DCHECK(!mapped.is_null()); + mapped = device->Clone(); // Notify all observers. for (auto& observer : device_observer_list_)