mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: ensure SetPluginCanSave updated in PDFs (#44020)

Browse source 
fix: ensure SetPluginCanSave updated in PDFs

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot] 2024-09-30 14:52:14 +02:00 committed by GitHub
parent c895d45a6d
commit 0a4b0de4f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
shell/browser/electron_pdf_document_helper_client.cc
View file

@ -4,8 +4,14 @@
#include "shell/browser/electron_pdf_document_helper_client.h" #include "shell/browser/electron_pdf_document_helper_client.h"
#include "chrome/browser/pdf/pdf_viewer_stream_manager.h"
#include "chrome/common/content_restriction.h"
#include "components/pdf/browser/pdf_frame_util.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents.h"
#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
#include "pdf/content_restriction.h" #include "pdf/content_restriction.h"
#include "pdf/pdf_features.h"
#include "shell/browser/api/electron_api_web_contents.h" #include "shell/browser/api/electron_api_web_contents.h"
ElectronPDFDocumentHelperClient::ElectronPDFDocumentHelperClient() = default; ElectronPDFDocumentHelperClient::ElectronPDFDocumentHelperClient() = default;
@ -15,8 +21,8 @@ void ElectronPDFDocumentHelperClient::UpdateContentRestrictions(
content::RenderFrameHost* render_frame_host, content::RenderFrameHost* render_frame_host,
int content_restrictions) { int content_restrictions) {
// UpdateContentRestrictions potentially gets called twice from // UpdateContentRestrictions potentially gets called twice from
// pdf/pdf_view_web_plugin.cc. The first time it is potentially called is // pdf/pdf_view_web_plugin.cc. The first time it is potentially called is
// when loading starts and it is called with a restriction on printing. The // when loading starts and it is called with a restriction on printing. The
// second time it is called is when loading is finished and if printing is // second time it is called is when loading is finished and if printing is
// allowed there won't be a printing restriction passed, so we can use this // allowed there won't be a printing restriction passed, so we can use this
// second call to notify that the pdf document is ready to print. // second call to notify that the pdf document is ready to print.
@ -31,3 +37,29 @@ void ElectronPDFDocumentHelperClient::UpdateContentRestrictions(
} }
} }
} }
void ElectronPDFDocumentHelperClient::SetPluginCanSave(
content::RenderFrameHost* render_frame_host,
bool can_save) {
if (chrome_pdf::features::IsOopifPdfEnabled()) {
auto* pdf_viewer_stream_manager =
pdf::PdfViewerStreamManager::FromWebContents(
content::WebContents::FromRenderFrameHost(render_frame_host));
if (!pdf_viewer_stream_manager) {
return;
}
content::RenderFrameHost* embedder_host =
pdf_frame_util::GetEmbedderHost(render_frame_host);
CHECK(embedder_host);
pdf_viewer_stream_manager->SetPluginCanSave(embedder_host, can_save);
return;
}
auto* guest_view =
extensions::MimeHandlerViewGuest::FromRenderFrameHost(render_frame_host);
if (guest_view) {
guest_view->SetPluginCanSave(can_save);
}
}

2
shell/browser/electron_pdf_document_helper_client.h
View file

@ -22,7 +22,7 @@ class ElectronPDFDocumentHelperClient : public pdf::PDFDocumentHelperClient {
void OnPDFHasUnsupportedFeature(content::WebContents* contents) override {} void OnPDFHasUnsupportedFeature(content::WebContents* contents) override {}
void OnSaveURL(content::WebContents* contents) override {} void OnSaveURL(content::WebContents* contents) override {}
void SetPluginCanSave(content::RenderFrameHost* render_frame_host, void SetPluginCanSave(content::RenderFrameHost* render_frame_host,
bool can_save) override {} bool can_save) override;
}; };
#endif // ELECTRON_SHELL_BROWSER_ELECTRON_PDF_DOCUMENT_HELPER_CLIENT_H_ #endif // ELECTRON_SHELL_BROWSER_ELECTRON_PDF_DOCUMENT_HELPER_CLIENT_H_