mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: fix ClientRequest.getUploadProgress (#21388)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-12-06 13:14:44 -08:00 committed by GitHub
parent dc9beda182
commit 092e00f7f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/browser/api/net.js
View file

@ -454,7 +454,7 @@ class ClientRequest extends Writable {
} }
getUploadProgress () { getUploadProgress () {
return { ...this._uploadProgress } || { active: false } return this._uploadProgress ? { ...this._uploadProgress } : { active: false }
} }
} }

11
spec-main/api-net-spec.ts
View file

@ -1205,6 +1205,17 @@ describe('net module', () => {
}) })
}) })
it('should report upload progress', async () => {
const serverUrl = await respondOnce.toSingleURL((request, response) => {
response.end()
})
const netRequest = net.request({ url: serverUrl, method: 'POST' })
expect(netRequest.getUploadProgress()).to.deep.equal({ active: false })
netRequest.end(Buffer.from('hello'))
const [position, total] = await emittedOnce(netRequest, 'upload-progress')
expect(netRequest.getUploadProgress()).to.deep.equal({ active: true, started: true, current: position, total })
})
it('should emit error event on server socket destroy', async () => { it('should emit error event on server socket destroy', async () => {
const serverUrl = await respondOnce.toSingleURL((request) => { const serverUrl = await respondOnce.toSingleURL((request) => {
request.socket.destroy() request.socket.destroy()