mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

platform_util code should not involve V8 code

Browse source
This commit is contained in:
Cheng Zhao 2016-11-17 11:22:09 +09:00
parent 622bad1cff
commit 090a5d9a61
3 changed files with 90 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

16
atom/common/api/atom_api_shell.cc
View file

@ -42,6 +42,16 @@ struct Converter<base::win::ShortcutOperation> {
namespace {
void OnOpenExternalFinished(
v8::Isolate* isolate,
const base::Callback<void(v8::Local<v8::Value>)>& callback,
const std::string& error) {
if (error.empty())
callback.Run(v8::Null(isolate));
else
callback.Run(v8::String::NewFromUtf8(isolate, error.c_str()));
}
bool OpenExternal(
#if defined(OS_WIN)
const base::string16& url,
@ -58,9 +68,11 @@ bool OpenExternal(
}
if (args->Length() >= 3) {
platform_util::OpenExternalCallback callback;
base::Callback<void(v8::Local<v8::Value>)> callback;
if (args->GetNext(&callback)) {
platform_util::OpenExternal(url, activate, callback);
platform_util::OpenExternal(
url, activate,
base::Bind(&OnOpenExternalFinished, args->isolate(), callback));
return true;
}
}