mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: use WebContents event to test beforeunload (#23699)

Browse source
This commit is contained in:
Cheng Zhao 2020-05-26 22:21:38 +09:00 • committed by GitHub
parent 0dabd5e8c7
commit 08f288faf1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 97 additions and 134 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec-main/api-web-contents-spec.ts
View file

@ -42,23 +42,22 @@ describe('webContents module', () => {
});
describe('will-prevent-unload event', function () {
// TODO(nornagon): de-flake this properly
this.retries(3);
afterEach(closeAllWindows);
it('does not emit if beforeunload returns undefined', (done) => {
it('does not emit if beforeunload returns undefined', async () => {
const w = new BrowserWindow({ show: false });
w.once('closed', () => done());
w.webContents.once('will-prevent-unload', () => {
expect.fail('should not have fired');
});
w.loadFile(path.join(__dirname, 'fixtures', 'api', 'close-beforeunload-undefined.html'));
await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'close-beforeunload-undefined.html'));
const wait = emittedOnce(w, 'closed');
w.close();
await wait;
});
it('emits if beforeunload returns false', async () => {
const w = new BrowserWindow({ show: false });
await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'close-beforeunload-false.html'));
w.webContents.executeJavaScript('run()', true);
w.close();
await emittedOnce(w.webContents, 'will-prevent-unload');
});
@ -66,8 +65,9 @@ describe('webContents module', () => {
const w = new BrowserWindow({ show: false });
w.webContents.once('will-prevent-unload', event => event.preventDefault());
await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'close-beforeunload-false.html'));
w.webContents.executeJavaScript('run()', true);
await emittedOnce(w, 'closed');
const wait = emittedOnce(w, 'closed');
w.close();
await wait;
});
});