mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Implementing abort workflow, emitting error events.

Browse source
This commit is contained in:
ali.ibrahim 2016-09-28 15:07:54 +02:00
parent cbbc4376ca
commit 08947682b0
5 changed files with 84 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/api/atom_api_url_request.cc
View file

@ -135,7 +135,7 @@ void URLRequest::BuildPrototype(v8::Isolate* isolate,
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
// Request API
.MakeDestroyable()
.SetMethod("writeBuffer", &URLRequest::Write)
.SetMethod("write", &URLRequest::Write)
.SetMethod("abort", &URLRequest::Abort)
.SetMethod("setExtraHeader", &URLRequest::SetExtraHeader)
.SetMethod("removeExtraHeader", &URLRequest::RemoveExtraHeader)
@ -212,6 +212,10 @@ void URLRequest::OnResponseCompleted() {
atom_request_ = nullptr;
}
void URLRequest::OnError(const std::string& error) {
auto error_object = v8::Exception::Error(mate::StringToV8(isolate(), error));
EmitRequestEvent("error", error_object);
}
int URLRequest::StatusCode() const {
if (auto response_headers = atom_request_->GetResponseHeaders()) {