From 0864b87b56d24be9ee90b414d504db930b067043 Mon Sep 17 00:00:00 2001 From: "electron-roller[bot]" <84116207+electron-roller[bot]@users.noreply.github.com> Date: Fri, 10 May 2024 11:43:00 -0400 Subject: [PATCH] chore: bump chromium to 124.0.6367.201 (30-x-y) (#42117) * chore: bump chromium in DEPS to 124.0.6367.201 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> --- DEPS | 2 +- patches/chromium/.patches | 1 - .../chromium/cherry-pick-b2cc7b7ac538.patch | 99 ------------------- 3 files changed, 1 insertion(+), 101 deletions(-) delete mode 100644 patches/chromium/cherry-pick-b2cc7b7ac538.patch diff --git a/DEPS b/DEPS index ca8434cd1fb..4c03023e2dc 100644 --- a/DEPS +++ b/DEPS @@ -2,7 +2,7 @@ gclient_gn_args_from = 'src' vars = { 'chromium_version': - '124.0.6367.157', + '124.0.6367.201', 'node_version': 'v20.11.1', 'nan_version': diff --git a/patches/chromium/.patches b/patches/chromium/.patches index 3288878e0b4..ce25861d4c8 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -131,4 +131,3 @@ fix_getcursorscreenpoint_wrongly_returns_0_0.patch fix_add_support_for_skipping_first_2_no-op_refreshes_in_thumb_cap.patch refactor_expose_file_system_access_blocklist.patch cherry-pick-013961609785.patch -cherry-pick-b2cc7b7ac538.patch diff --git a/patches/chromium/cherry-pick-b2cc7b7ac538.patch b/patches/chromium/cherry-pick-b2cc7b7ac538.patch deleted file mode 100644 index a8f2d5fb86f..00000000000 --- a/patches/chromium/cherry-pick-b2cc7b7ac538.patch +++ /dev/null @@ -1,99 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Ken Rockot -Date: Wed, 8 May 2024 15:32:48 +0000 -Subject: Viz: Tolerate SinkGroup destruction during submit - -Fixed: 339266700 -Change-Id: I8c0ea8c540948016346b00db64fe33260d2446f0 -Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523748 -Reviewed-by: Kyle Charbonneau -Reviewed-by: Jonathan Ross -Commit-Queue: Ken Rockot -Cr-Commit-Position: refs/heads/main@{#1298119} - -diff --git a/components/viz/service/frame_sinks/frame_sink_bundle_impl.cc b/components/viz/service/frame_sinks/frame_sink_bundle_impl.cc -index a43e274a920a7cc189652c29eb2fe4a09ab66ded..9fefc2446d9c95964db512e4c98654c3fcc4e8b4 100644 ---- a/components/viz/service/frame_sinks/frame_sink_bundle_impl.cc -+++ b/components/viz/service/frame_sinks/frame_sink_bundle_impl.cc -@@ -4,12 +4,15 @@ - - #include "components/viz/service/frame_sinks/frame_sink_bundle_impl.h" - -+#include - #include - #include - - #include "base/check.h" - #include "base/functional/bind.h" -+#include "base/memory/raw_ptr.h" - #include "base/memory/raw_ref.h" -+#include "base/memory/weak_ptr.h" - #include "build/build_config.h" - #include "components/viz/service/frame_sinks/compositor_frame_sink_impl.h" - #include "components/viz/service/frame_sinks/frame_sink_manager_impl.h" -@@ -45,6 +48,10 @@ class FrameSinkBundleImpl::SinkGroup : public BeginFrameObserver { - - bool IsEmpty() const { return frame_sinks_.empty(); } - -+ base::WeakPtr GetWeakPtr() { -+ return weak_ptr_factory_.GetWeakPtr(); -+ } -+ - void AddFrameSink(uint32_t sink_id) { - frame_sinks_.insert(sink_id); - -@@ -206,6 +213,8 @@ class FrameSinkBundleImpl::SinkGroup : public BeginFrameObserver { - std::set unacked_submissions_; - - BeginFrameArgs last_used_begin_frame_args_; -+ -+ base::WeakPtrFactory weak_ptr_factory_{this}; - }; - - FrameSinkBundleImpl::FrameSinkBundleImpl( -@@ -282,8 +291,9 @@ void FrameSinkBundleImpl::SetWantsBeginFrameAcks(uint32_t sink_id) { - - void FrameSinkBundleImpl::Submit( - std::vector submissions) { -- std::set groups; -- std::set affected_groups; -+ std::map, base::WeakPtr> groups; -+ std::map, base::WeakPtr> affected_groups; -+ - // Count the frame submissions before processing anything. This ensures that - // any frames submitted here will be acked together in a batch, and not acked - // individually in case they happen to ack synchronously within -@@ -294,10 +304,10 @@ void FrameSinkBundleImpl::Submit( - // through to the client without batching. - for (auto& submission : submissions) { - if (auto* group = GetSinkGroup(submission->sink_id)) { -- groups.insert(group); -+ groups.emplace(group, group->GetWeakPtr()); - if (submission->data->is_frame()) { - group->WillSubmitFrame(submission->sink_id); -- affected_groups.insert(group); -+ affected_groups.emplace(group, group->GetWeakPtr()); - } - } - } -@@ -327,12 +337,16 @@ void FrameSinkBundleImpl::Submit( - } - } - -- for (auto* group : groups) { -- group->DidFinishFrame(); -+ for (const auto& [unsafe_group, weak_group] : groups) { -+ if (weak_group) { -+ weak_group->DidFinishFrame(); -+ } - } - -- for (auto* group : affected_groups) { -- group->FlushMessages(); -+ for (const auto& [unsafe_group, weak_group] : affected_groups) { -+ if (weak_group) { -+ weak_group->FlushMessages(); -+ } - } - } -